Frontend Code Review Policy. Frontend Code Review Policy

Speed of iteration over perfection - Frontend development is inherently iterative. It is often better to ship something and then iterate on it than trying to get it perfect from the get go.

Not all changes are equal - CSS changes shouldn't require review. With the advent of LLM's, a lot of NextJS code feels solved as well.

Review Requirements by Change Type

CSS/HTML-only changes: No review required

• Pure styling changes (margins, colors, fonts, layouts)

• HTML structure changes without logic

• Exception: Changes to key components (e.g. StoryCard, IndexContent)

• Developer is responsible for visual QA before merging

Very Small Component logic changes: No review required

• Changes to the frontend tests

• Piping some variable around in order to display it (e.g. adding a date)

• Adding/modifying some simple logic

• One-line bug fixes

• Developer is responsible for visual QA and LLM-core review before merging

Component logic changes: Relaxed review requirements (see below)

• Data transformation and display logic

• Any React or NextJS component change that follows standard React/NextJS best practices

  • Adding hooks

  • State management changes

  • Event handlers and user interactions (useEffect)

  • Props and type definitions

  • etc.

Critical paths: Regular review requirements

• Authentication/authorization flows

• Payment or checkout flows (in the future)

• Data mutations that affect other users

• Any code in common or backend (i.e. the change is not purely a frontend change)

Relaxed Review Requirements

1. Before requesting a review, the submitter is expected to have ask an LLM to review the code and find any code smells, bugs, things that might bite us later on, gotchas, or design problems, and address them. This process should be repeated until the LLM is satisfied.

2. Review should be up for a day to give others a chance to respond

3. Code can be pushed if either of these two conditions is met:

   1. Approval from another UpTrust dev

   2. 24 hours + passing the LLM review

AMA with Jordan Myska Allen. Wednesday 2/4 at 12:30pm CST

Founder and CEO of UpTrust, founder of Relatefulness... solving seemingly impossible social problems and having fun doing it

#heywait 

Chinook . Here is my story page.

how do i browse all the conversations? This might be an obvious question but I don't understand....

Is there a way to just see all the threads by date? 

I see the two tabs for Top convos for you and Your Timeline and I also see Your Topics. But are all the threads showing up in one or all of them?

Is there a place to report minor UpTrust bugs? I mentioned a couple of things at TBEX and just noticed another (very minor) thing, which is that it automatically adds a full stop (period to you in the US) to the end of every optional title.  So here, for instance, I ask a question in the title, which ends with a question mark, but that also then has a period placed after it.  Pedantic, I know, but I guess you might want to know these things... good luck guys!

#UpTrustFeedback grab bag

1. I can't write two posts at once.  It shows a current draft if I try to write a new draft in a new tab.  But also it says "can't post, no content", because somehow it hasn't sync'd properly.  I'm currently getting around this by just posting the first one knowing I can edit it later.
2. You just lost some text that I had drafted as a comment [EDIT: maybe it's still there but I can't find it].  This is a result of two distinct failures in how your app is set up:
   1. You didn't use `onbeforeunload` to keep the page from changing when there was drafted text that hadn't been used. "Are you sure you want to..."
   2. I wasn't intending to change pages! I held the Cmd key while clicking on Home, which, if you use links in an ordinary way, would have caused that click to open the link in a new tab. But you're doing some fancy extra javascript, and so it didn't, and instead it just navigated to Home in the same tab and lost my comment draft.
3. I just now tried to use cmd+[ to de-indent the list item, and this navigated to a completely different screen, which would have lost the text again if you guys weren't pretty good at saving drafts.  Please don't violate standard keyboard shortcut expectations by doing something that looks like it completely loses all of my work!
4. If I put a title, it shows up as small bold text at the top of the post.  But if I put a header in the post, I can make the post have a title, visually.  But the "title" is not it.  This is confusing and weird.
5. In general, there are too many options.  Like formatting is kinda nice but it evokes the idea that we're gonna be all fancy.  As an extreme example, why on earth am I choosing whether a link should open in a new tab?  Just have some sane default and don't present me with so many choices.  (Good sane default is "new tab for off domain, same tab for same domain")
6. The lil icon buttons below the post are too tiny.  Also it's confusing to have the reply count distinct from the button to make a reply. I keep wanting to push the reply count button instead.
7. Why are you summarizing all emoji reactions as eg ♡ 4 ? That's not a very good way to summarize 🤔🤷😤😒.  Pick a non-heart more neutral icon, or show the actual reacji! (I'd recommend the latter, as it's much richer).
8. Don't call what we write or read here "content" 🤮  The word has much of its history in advertising and marketing—it's the thing that's not the ads, around which ads can be placed.  That starts us off with a framing that what we write doesn't matter, it's just stuff that fills the space.  Instead be willing to talk about things as "perspectives" or "takes" or if you don't want to be so bold, just "posts".
9. If you can't edit a post after people have reacted to it (which is fairly sensible!) then it should tell you that when you hit the EDIT button, not the SAVE button (after making said edits)
10. Lots of random other lil things
    1. sometimes the title of the page is stuck on a different post name than the one I'm on
    2. inconsistent use of cursor:pointer when hovering over buttons (notable, it's absent from the profile icon in the top right)
11. no way to follow specific people? maybe this is intentional? you want to magic-algo things?  but it's sad—I see someone say something interesting and I want to like...  not lose track of them. and maybe the way to do it is to updoot more of their bops, but it feels somehow unsatisfying, and annoying if I'm like "cool I'm done gonna sign off for now"
12. if I hit the feed again, either show me something I haven't seen before or say "that's all for today", but don't just show me the same few posts I saw before

Current Session "instructions" (Feb 26): Converse, and see if nudges happen. nudges 

We launched a system where the AI bots can automatically detect intervention points. We need you to make a bunch of comments and new posts to see if they'll engage. So this week we're asking you to engage a bunch, if you can!

It's a little rudimentary at the moment so sometimes you'll get multiple bots responding on multiple posts. We'd love your feedback on which ones you like, don't, when it seemed to miss the spot, anything else you notice. 

Thanks and love yall

J (and the UpTrust team)
p.s. this week I'm at an investor meeting so dara will be with you

# [Optional Zoom](https://us02web.zoom.us/j/86795216050?pwd=TllxSzYrTFFXTW5LRmg3WUQrT04vdz09) with Jordan and Dara at least, for faces, questions, help, etc:

Finally they learned to cut off people's mics. Hot take: If the media wasn’t so Green and did this in 2016, I think Hillary would have won.

What do you think about this short post? This is so short

Some integral philosophy/analysis behind TreeView. Forums like Reddit and Facebook are essentially "Orange" interaction paradigms—there's a static "original post" and a fixed hierarchy. Some benefits of this are that you get some sense of coherence to a conversation, and if you're ten layers deep in replies, you can quickly navigate your way back to the original post to try and reclaim some context. Some drawbacks are that really cool content deep in threads hardly sees the light of day. Also, it's really confusing to navigate, and especially confusing as the tail winds up. (Facebook tries to avoid the contextlessness and lostness of orange by imposing a limit of three deep, but this curtails conversational flow which often goes in strange directions to find the good stuff).

Twitter and all of its clones are essentially "Green" interaction paradigms—you get a personally tailored feed of content that comes from anywhere in a given lineage/conversation. The first post you see could be from twelve layers deep in a convo, the next a reply to a post, and the next an original post. Some benefits of this is that deep content gets surfaced—a reply to a reply to a reply to a reply might be the most interesting bit of the conversation, and on twitter it gets to your feed immediately. Some drawbacks are that it often lacks context, and sometimes is purposely removed from context to be more inflammatory. I believe this contributes to the sound-bite post-truth world we're in today, where context, nuance, history don't matter, only quick dopamine hits.

We believe TreeView is the start of a "Teal" interaction paradigm which allows deep content to be surfaced while retaining the context of the conversation it is birthed from. We believe this will integrate the benefits of both hierarchical forum interactions and pluralistic twitter feeds. I say "start" because right now it still leans Orange; we haven't yet built out the bits where whenever you click onto a reply, it becomes the top-level thingy in the TreeView; nor the feature where you can link "original posts" to each other in playlists, or to multiple originals, and see that there's not really such a thing as an "OP" because all of us are proverbially standing on the shoulders of giants. So where we're going is you'll be able to get a relative hierarchy (a holarchy) of what conversational lineage content is nested inside of. We believe this is models more of "in person" conversation actually works than any of the current paradigms. And even just this start has helped me understand longer threads!

What are your sci-fi TV show recommendations? Some i loved that jump to mind:

• The Expanse
• Most of the Marvel stuff like Loki, What If?
• Rick and Morty
• Legends of Tomorrow Etc

Some integral philosophy/analysis behind TreeView. Forums like Reddit and Facebook are essentially "Orange" interaction paradigms—there's a static "original post" and a fixed hierarchy. Some benefits of this are that you get some sense of coherence to a conversation, and if you're ten layers deep in replies, you can quickly navigate your way back to the original post to try and reclaim some context. Some drawbacks are that really cool content deep in threads hardly sees the light of day. Also, it's really confusing to navigate, and especially confusing as the tail winds up. (Facebook tries to avoid the contextlessness and lostness of orange by imposing a limit of three deep, but this curtails conversational flow which often goes in strange directions to find the good stuff).

Twitter and all of its clones are essentially "Green" interaction paradigms—you get a personally tailored feed of content that comes from anywhere in a given lineage/conversation. The first post you see could be from twelve layers deep in a convo, the next a reply to a post, and the next an original post. Some benefits of this is that deep content gets surfaced—a reply to a reply to a reply to a reply might be the most interesting bit of the conversation, and on twitter it gets to your feed immediately. Some drawbacks are that it often lacks context, and sometimes is purposely removed from context to be more inflammatory. I believe this contributes to the sound-bite post-truth world we're in today, where context, nuance, history don't matter, only quick dopamine hits.

We believe TreeView is the start of a "Teal" interaction paradigm which allows deep content to be surfaced while retaining the context of the conversation it is birthed from. We believe this will integrate the benefits of both hierarchical forum interactions and pluralistic twitter feeds. I say "start" because right now it still leans Orange; we haven't yet built out the bits where whenever you click onto a reply, it becomes the top-level thingy in the TreeView; nor the feature where you can link "original posts" to each other in playlists, or to multiple originals, and see that there's not really such a thing as an "OP" because all of us are proverbially standing on the shoulders of giants. So where we're going is you'll be able to get a relative hierarchy (a holarchy) of what conversational lineage content is nested inside of. We believe this is models more of "in person" conversation actually works than any of the current paradigms. And even just this start has helped me understand longer threads!

Some integral philosophy/analysis behind TreeView. Forums like Reddit and Facebook are essentially "Orange" interaction paradigms—there's a static "original post" and a fixed hierarchy. Some benefits of this are that you get some sense of coherence to a conversation, and if you're ten layers deep in replies, you can quickly navigate your way back to the original post to try and reclaim some context. Some drawbacks are that really cool content deep in threads hardly sees the light of day. Also, it's really confusing to navigate, and especially confusing as the tail winds up. (Facebook tries to avoid the contextlessness and lostness of orange by imposing a limit of three deep, but this curtails conversational flow which often goes in strange directions to find the good stuff).

Twitter and all of its clones are essentially "Green" interaction paradigms—you get a personally tailored feed of content that comes from anywhere in a given lineage/conversation. The first post you see could be from twelve layers deep in a convo, the next a reply to a post, and the next an original post. Some benefits of this is that deep content gets surfaced—a reply to a reply to a reply to a reply might be the most interesting bit of the conversation, and on twitter it gets to your feed immediately. Some drawbacks are that it often lacks context, and sometimes is purposely removed from context to be more inflammatory. I believe this contributes to the sound-bite post-truth world we're in today, where context, nuance, history don't matter, only quick dopamine hits.

We believe TreeView is the start of a "Teal" interaction paradigm which allows deep content to be surfaced while retaining the context of the conversation it is birthed from. We believe this will integrate the benefits of both hierarchical forum interactions and pluralistic twitter feeds. I say "start" because right now it still leans Orange; we haven't yet built out the bits where whenever you click onto a reply, it becomes the top-level thingy in the TreeView; nor the feature where you can link "original posts" to each other in playlists, or to multiple originals, and see that there's not really such a thing as an "OP" because all of us are proverbially standing on the shoulders of giants. So where we're going is you'll be able to get a relative hierarchy (a holarchy) of what conversational lineage content is nested inside of. We believe this is models more of "in person" conversation actually works than any of the current paradigms. And even just this start has helped me understand longer threads!

Current Session "instructions" (Feb 26): Converse, and see if nudges happen. nudges 

We launched a system where the AI bots can automatically detect intervention points. We need you to make a bunch of comments and new posts to see if they'll engage. So this week we're asking you to engage a bunch, if you can!

It's a little rudimentary at the moment so sometimes you'll get multiple bots responding on multiple posts. We'd love your feedback on which ones you like, don't, when it seemed to miss the spot, anything else you notice. 

Thanks and love yall

J (and the UpTrust team)
p.s. this week I'm at an investor meeting so dara will be with you

# [Optional Zoom](https://us02web.zoom.us/j/86795216050?pwd=TllxSzYrTFFXTW5LRmg3WUQrT04vdz09) with Jordan and Dara at least, for faces, questions, help, etc:

testing images loading.

What are your sci-fi TV show recommendations? Some i loved that jump to mind:

• The Expanse
• Most of the Marvel stuff like Loki, What If?
• Rick and Morty
• Legends of Tomorrow Etc